Patchwork [OpenWrt-Devel] bcm63xx spi fix-fix

login
register
Submitter Anthony Blakemore
Date 2011-07-25 18:33:47
Message ID <BLU0-SMTP1212C570915719591568785DB330@phx.gbl>
Download mbox | patch
Permalink /patch/1262/
State Accepted
Delegated to: Jonas Gorski
Headers show

Comments

Anthony Blakemore - 2011-07-25 18:33:47
In 240-spi.patch, spi registers for bcm6348 were all messed up. This patch fixes that.
It also fixes some spi commands for all bcm63xx.

Signed-off-by: Anthony Blakemore <stokie-ant@raverbaby.co.uk>
Jonas Gorski - 2011-07-25 19:55:46
On 25 July 2011 20:33, Anthony Blakemore <stokie-ant@raverbaby.co.uk> wrote:
> ....

Thanks, applied! I also applied this to 3.0. Btw, I noticed you
dropped the _MSG_DATA_SIZE change, I agree that it should stay 0x3f.


Jonas

Patch

Index: target/linux/brcm63xx/patches-2.6.39/240-spi.patch
===================================================================
--- target/linux/brcm63xx/patches-2.6.39/240-spi.patch	(revision 27772)
+++ target/linux/brcm63xx/patches-2.6.39/240-spi.patch	(working copy)
@@ -195,17 +195,17 @@ 
 +#define SPI_BCM_6338_SPI_RX_DATA_SIZE	0x3f
 +
 +/* BCM 6348 SPI core */
-+#define SPI_BCM_6348_SPI_INT_MASK_ST	0x00
-+#define SPI_BCM_6348_SPI_INT_STATUS	0x01
-+#define SPI_BCM_6348_SPI_CMD		0x02	/* 16-bits register */
-+#define SPI_BCM_6348_SPI_FILL_BYTE	0x04
-+#define SPI_BCM_6348_SPI_CLK_CFG	0x05
-+#define SPI_BCM_6348_SPI_ST		0x06
-+#define SPI_BCM_6348_SPI_INT_MASK	0x07
-+#define SPI_BCM_6348_SPI_RX_TAIL	0x08
-+#define SPI_BCM_6348_SPI_MSG_TAIL	0x10
-+#define SPI_BCM_6348_SPI_MSG_DATA	0x40
-+#define SPI_BCM_6348_SPI_MSG_CTL	0x42
++#define SPI_BCM_6348_SPI_CMD		0x00	/* 16-bits register */
++#define SPI_BCM_6348_SPI_INT_STATUS	0x02
++#define SPI_BCM_6348_SPI_INT_MASK_ST	0x03
++#define SPI_BCM_6348_SPI_INT_MASK	0x04
++#define SPI_BCM_6348_SPI_ST		0x05
++#define SPI_BCM_6348_SPI_CLK_CFG	0x06
++#define SPI_BCM_6348_SPI_FILL_BYTE	0x07
++#define SPI_BCM_6348_SPI_MSG_TAIL	0x09
++#define SPI_BCM_6348_SPI_RX_TAIL	0x0b
++#define SPI_BCM_6348_SPI_MSG_CTL	0x40
++#define SPI_BCM_6348_SPI_MSG_DATA	0x41
 +#define SPI_BCM_6348_SPI_MSG_DATA_SIZE	0x3f
 +#define SPI_BCM_6348_SPI_RX_DATA	0x80
 +#define SPI_BCM_6348_SPI_RX_DATA_SIZE	0x3f
@@ -244,10 +244,10 @@ 
 +#define SPI_MSG_TYPE_SHIFT		14
 +
 +/* Command */
-+#define SPI_CMD_NOOP			0x01
-+#define SPI_CMD_SOFT_RESET		0x02
-+#define SPI_CMD_HARD_RESET		0x04
-+#define SPI_CMD_START_IMMEDIATE		0x08
++#define SPI_CMD_NOOP			0x00
++#define SPI_CMD_SOFT_RESET		0x01
++#define SPI_CMD_HARD_RESET		0x02
++#define SPI_CMD_START_IMMEDIATE		0x03
 +#define SPI_CMD_COMMAND_SHIFT		0
 +#define SPI_CMD_COMMAND_MASK		0x000f
 +#define SPI_CMD_DEVICE_ID_SHIFT		4