Patchwork [OpenWrt-Devel] enable kernel support for ALSA midi

login
register
Submitter Adam Goode
Date 2012-04-30 02:12:59
Message ID <CADN=Wdq4wf+=jqdSFWWa1oTQd-6GJQJ4DncKg2OzTqY607xsaQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/2145/
State Superseded
Delegated to: John Crispin
Headers show

Comments

Adam Goode - 2012-04-30 02:12:59
Enable the real ALSA midi interface (seq) in the kernel. The existing
rawmidi interface is still present. This allows for the alsa midi
utilities to work.

Signed-off-by: Adam Goode <adam@spicenitz.org>

---
John Crispin - 2012-06-03 11:28:24
On 30/04/12 04:12, Adam Goode wrote:
> Enable the real ALSA midi interface (seq) in the kernel. The existing
> rawmidi interface is still present. This allows for the alsa midi
> utilities to work.
> 
> Signed-off-by: Adam Goode <adam@spicenitz.org>
> 
> ---
> 
> Index: package/kernel/modules/sound.mk
> ===================================================================
> --- package/kernel/modules/sound.mk	(revision 31532)
> +++ package/kernel/modules/sound.mk	(working copy)
> @@ -42,6 +42,9 @@
>  	snd-seq-device \
>  	snd-rawmidi \
>  	snd-timer \
> +	snd-seq \
> +	snd-seq-midi-event \
> +	snd-seq-midi \
>  	snd-pcm \
>  	snd-mixer-oss \
>  	snd-pcm-oss

Hi

midi is not really part of the sound-core package

you should rather package them in a seperate kmod-snd-midi or similar

John
Adam Goode - 2012-07-07 13:42:57
On Sun, Jun 3, 2012 at 7:28 AM, John Crispin <john@phrozen.org> wrote:
> On 30/04/12 04:12, Adam Goode wrote:
>> Enable the real ALSA midi interface (seq) in the kernel. The existing
>> rawmidi interface is still present. This allows for the alsa midi
>> utilities to work.
>>
>> Signed-off-by: Adam Goode <adam@spicenitz.org>
>>
>> ---
>>
>> Index: package/kernel/modules/sound.mk
>> ===================================================================
>> --- package/kernel/modules/sound.mk   (revision 31532)
>> +++ package/kernel/modules/sound.mk   (working copy)
>> @@ -42,6 +42,9 @@
>>       snd-seq-device \
>>       snd-rawmidi \
>>       snd-timer \
>> +     snd-seq \
>> +     snd-seq-midi-event \
>> +     snd-seq-midi \
>>       snd-pcm \
>>       snd-mixer-oss \
>>       snd-pcm-oss
>
> Hi
>
> midi is not really part of the sound-core package
>
> you should rather package them in a seperate kmod-snd-midi or similar
>
> John

I will try to do this, but note that "rawmidi" is already supported in
the sound-core package (so there is basic, but incomplete, midi
support in core).

Also, for reference, here are the sizes of the new modules:

78292 snd-seq.ko
8656 snd-seq-midi-event.ko
10220 snd-seq-midi.ko


Adam

Patch

Index: package/kernel/modules/sound.mk
===================================================================
--- package/kernel/modules/sound.mk	(revision 31532)
+++ package/kernel/modules/sound.mk	(working copy)
@@ -42,6 +42,9 @@ 
 	snd-seq-device \
 	snd-rawmidi \
 	snd-timer \
+	snd-seq \
+	snd-seq-midi-event \
+	snd-seq-midi \
 	snd-pcm \
 	snd-mixer-oss \
 	snd-pcm-oss
@@ -54,6 +57,9 @@ 
 	$(LINUX_DIR)/sound/core/seq/snd-seq-device.$(LINUX_KMOD_SUFFIX) \
 	$(LINUX_DIR)/sound/core/snd-rawmidi.$(LINUX_KMOD_SUFFIX) \
 	$(LINUX_DIR)/sound/core/snd-timer.$(LINUX_KMOD_SUFFIX) \
+	$(LINUX_DIR)/sound/core/seq/snd-seq.$(LINUX_KMOD_SUFFIX) \
+	$(LINUX_DIR)/sound/core/seq/snd-seq-midi-event.$(LINUX_KMOD_SUFFIX) \
+	$(LINUX_DIR)/sound/core/seq/snd-seq-midi.$(LINUX_KMOD_SUFFIX) \
 	$(LINUX_DIR)/sound/core/snd-pcm.$(LINUX_KMOD_SUFFIX) \
 	$(LINUX_DIR)/sound/core/oss/snd-mixer-oss.$(LINUX_KMOD_SUFFIX) \
 	$(LINUX_DIR)/sound/core/oss/snd-pcm-oss.$(LINUX_KMOD_SUFFIX)