| Submitter | Moritz Warning |
|---|---|
| Date | 2012-06-09 23:25:31 |
| Message ID | <4FD3DB6B.2030001@web.de> |
| Download | mbox | patch |
| Permalink | /patch/2256/ |
| State | Accepted |
| Delegated to: | Jo-Philipp Wich |
| Headers | show |
Comments
Thanks ! I included the patch in the Ninux firmware, as soon as I have it tested I will report. However the patch looks so trivial that I would ask to package maintainer to commit it immediatly :) Moritz maybe you are interested in forking our git repository: https://github.com/ninuxorg/nodogsplashninux Saverio 2012/6/10 Moritz Warning <moritzwarning@web.de>: > Starting nodogsplash there is the following warning on the console: > > Using intrapositioned negation (`--option ! this`) is deprecated in > favor of extrapositioned (`! --option this`). > > Attached is a trivial patch to fix the issue. > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel >
Patch
--- a/src/fw_iptables.c +++ b/src/fw_iptables.c @@ -449,7 +449,7 @@ iptables_fw_init(void) { /* CHAIN_TO_ROUTER, related and established packets ACCEPT */ rc |= iptables_do_command("-t filter -A " CHAIN_TO_ROUTER " -m state --state RELATED,ESTABLISHED -j ACCEPT"); /* CHAIN_TO_ROUTER, bogus SYN packets DROP */ - rc |= iptables_do_command("-t filter -A " CHAIN_TO_ROUTER " -p tcp --tcp-flags SYN SYN --tcp-option \\! 2 -j DROP"); + rc |= iptables_do_command("-t filter -A " CHAIN_TO_ROUTER " -p tcp --tcp-flags SYN SYN \\! --tcp-option 2 -j DROP"); /* CHAIN_TO_ROUTER, packets to HTTP listening on gw_port on router ACCEPT */ rc |= iptables_do_command("-t filter -A " CHAIN_TO_ROUTER " -p tcp --dport %d -j ACCEPT", gw_port);