Patchwork [OpenWrt-Devel,2/2] uClibc: enable SSP

login
register
Submitter Aleksander Morgado
Date 2013-02-13 08:21:22
Message ID <1360743682-4315-2-git-send-email-aleksander@lanedo.com>
Download mbox | patch
Permalink /patch/3276/
State Rejected
Delegated to: Florian Fainelli
Headers show

Comments

Aleksander Morgado - 2013-02-13 08:21:22
Needed for systemd-udev compilation.

Signed-off-by: Aleksander Morgado <aleksander@lanedo.com>
---
 toolchain/uClibc/config-0.9.33.2/common | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Florian Fainelli - 2013-02-13 11:22:46
On 02/13/2013 09:21 AM, Aleksander Morgado wrote:
> Needed for systemd-udev compilation.

Why would we need this at all? I would rather you teach systemd-udev 
about the availability of ssp.

>
> Signed-off-by: Aleksander Morgado <aleksander@lanedo.com>
> ---
>   toolchain/uClibc/config-0.9.33.2/common | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/toolchain/uClibc/config-0.9.33.2/common b/toolchain/uClibc/config-0.9.33.2/common
> index f806194..1af90da 100644
> --- a/toolchain/uClibc/config-0.9.33.2/common
> +++ b/toolchain/uClibc/config-0.9.33.2/common
> @@ -154,7 +154,7 @@ UCLIBC_HAS_SHADOW=y
>   UCLIBC_HAS_SIGNUM_MESSAGES=y
>   UCLIBC_HAS_SOCKET=y
>   UCLIBC_HAS_SOFT_FLOAT=y
> -# UCLIBC_HAS_SSP is not set
> +UCLIBC_HAS_SSP=y
>   UCLIBC_HAS_STDIO_AUTO_RW_TRANSITION=y
>   # UCLIBC_HAS_STDIO_BUFSIZ_1024 is not set
>   # UCLIBC_HAS_STDIO_BUFSIZ_2048 is not set
>
Aleksander Morgado - 2013-02-13 11:56:17
On 02/13/2013 12:22 PM, Florian Fainelli wrote:
> 
> 
> On 02/13/2013 09:21 AM, Aleksander Morgado wrote:
>> Needed for systemd-udev compilation.
> 
> Why would we need this at all? I would rather you teach systemd-udev
> about the availability of ssp.


-fstack-protector, FORTIFY_SOURCE and such I guess; I'll try to disable
those defaults in the systemd compilation.


> 
>>
>> Signed-off-by: Aleksander Morgado <aleksander@lanedo.com>
>> ---
>>   toolchain/uClibc/config-0.9.33.2/common | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/toolchain/uClibc/config-0.9.33.2/common
>> b/toolchain/uClibc/config-0.9.33.2/common
>> index f806194..1af90da 100644
>> --- a/toolchain/uClibc/config-0.9.33.2/common
>> +++ b/toolchain/uClibc/config-0.9.33.2/common
>> @@ -154,7 +154,7 @@ UCLIBC_HAS_SHADOW=y
>>   UCLIBC_HAS_SIGNUM_MESSAGES=y
>>   UCLIBC_HAS_SOCKET=y
>>   UCLIBC_HAS_SOFT_FLOAT=y
>> -# UCLIBC_HAS_SSP is not set
>> +UCLIBC_HAS_SSP=y
>>   UCLIBC_HAS_STDIO_AUTO_RW_TRANSITION=y
>>   # UCLIBC_HAS_STDIO_BUFSIZ_1024 is not set
>>   # UCLIBC_HAS_STDIO_BUFSIZ_2048 is not set
>>

Patch

diff --git a/toolchain/uClibc/config-0.9.33.2/common b/toolchain/uClibc/config-0.9.33.2/common
index f806194..1af90da 100644
--- a/toolchain/uClibc/config-0.9.33.2/common
+++ b/toolchain/uClibc/config-0.9.33.2/common
@@ -154,7 +154,7 @@  UCLIBC_HAS_SHADOW=y
 UCLIBC_HAS_SIGNUM_MESSAGES=y
 UCLIBC_HAS_SOCKET=y
 UCLIBC_HAS_SOFT_FLOAT=y
-# UCLIBC_HAS_SSP is not set
+UCLIBC_HAS_SSP=y
 UCLIBC_HAS_STDIO_AUTO_RW_TRANSITION=y
 # UCLIBC_HAS_STDIO_BUFSIZ_1024 is not set
 # UCLIBC_HAS_STDIO_BUFSIZ_2048 is not set